Open
Conversation
octonato
force-pushed
the
octonato/logging-task-name
branch
from
3c96483 to
eba915c
Compare
patriknw
reviewed
Apr 17, 2026
| */ | ||
| default void assignTasks(String... taskIds) { | ||
| assignTasksAsync(taskIds).toCompletableFuture().join(); | ||
| default void assignTasks(TaskKey... taskKeys) { |
Contributor
There was a problem hiding this comment.
Requiring the key in client api? Is this going in the right direction?
I didn't notice when reviewing the runtime PR.
| } | ||
|
|
||
| override def assignTasksAsync(taskIds: String*): CompletionStage[Done] = { | ||
| override def assignTasksAsync(taskKeys: TaskKey*): CompletionStage[Done] = { |
Contributor
There was a problem hiding this comment.
I think it would be easier to keep task ids in the client api? For example, it's more difficult to pass around a composite key in http request/responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.